Re: [patch v8 15/24] frame, backtrace: allow targets to supply a frame unwinder

Pedro Alves
2013-12-16T19:02:13Z

On 12/16/2013 09:18 AM, Metzger, Markus T wrote:

>> ... parts look a bit unrelated. It'd be good to have
>> the rationale for this spelled out. I can understand
>> why they might be necessary, but I don't see why
>> target vs non-unwinders unwinders would be special here?
>
> Those changes are not directly related to target vs non-target
> unwinders. They are connected in that they allow new types
> of unwinders.

>
> I spelled out the rationale for each change in the commit
> message.

If I missed it, please point me at it. E.g., I didn't see a
rationale for the get_frame_unwind_stop_reason change.
Something like "We need to do X in get_frame_unwind_stop_reason
because otherwise, when we do Y, W doesn't work."

> Should I further split this patch into three?

IMO, yes.

Thanks,
--
Pedro Alves