From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28487 invoked by alias); 11 Dec 2013 12:24:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28475 invoked by uid 89); 11 Dec 2013 12:24:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2013 12:24:23 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBBCOENS014150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 11 Dec 2013 07:24:14 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBBCOCRA022895; Wed, 11 Dec 2013 07:24:13 -0500 Message-ID: <52A8596B.7080802@redhat.com> Date: Wed, 11 Dec 2013 12:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Metzger CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [patch v7 05/24] frame: artificial frame id's References: <1385735899-12481-1-git-send-email-markus.t.metzger@intel.com> <1385735899-12481-6-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1385735899-12481-6-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00424.txt.bz2 Can you please add a rationale to the patch's intro? I suppose one should find it digging around for the history of the series, but one shouldn't have to. Why wasn't this a problem before? On 11/29/2013 02:38 PM, Markus Metzger wrote: > 2013-11-29 Markus Metzger > > * frame.h (frame_id_build_artificial): New. > * frame.c (frame_id_build_artificial): New. > (frame_id_p): An artificial frame is valid. > (frame_id_eq): A frame is equal to itself. > --- > gdb/frame.c | 28 +++++++++++++++++++++------- > gdb/frame.h | 6 ++++++ > 2 files changed, 27 insertions(+), 7 deletions(-) > > diff --git a/gdb/frame.c b/gdb/frame.c > index bd31d87..931a33c 100644 > --- a/gdb/frame.c > +++ b/gdb/frame.c > @@ -504,6 +504,19 @@ frame_id_build_wild (CORE_ADDR stack_addr) > return id; > } > > +struct frame_id > +frame_id_build_artificial (CORE_ADDR code_addr, > + CORE_ADDR special_addr) > +{ > + struct frame_id id = null_frame_id; > + > + id.code_addr = code_addr; > + id.code_addr_p = 1; > + id.special_addr = special_addr; > + id.special_addr_p = 1; > + return id; > +} > + > int > frame_id_p (struct frame_id l) > { > @@ -514,6 +527,9 @@ frame_id_p (struct frame_id l) > /* outer_frame_id is also valid. */ > if (!p && memcmp (&l, &outer_frame_id, sizeof (l)) == 0) > p = 1; > + /* An artificial frame is also valid. */ > + if (!p && l.code_addr_p && l.special_addr_p) > + p = 1; > if (frame_debug) > { > fprintf_unfiltered (gdb_stdlog, "{ frame_id_p (l="); > @@ -537,13 +553,11 @@ frame_id_eq (struct frame_id l, struct frame_id r) > { > int eq; > > - if (!l.stack_addr_p && l.special_addr_p > - && !r.stack_addr_p && r.special_addr_p) > - /* The outermost frame marker is equal to itself. This is the > - dodgy thing about outer_frame_id, since between execution steps > - we might step into another function - from which we can't > - unwind either. More thought required to get rid of > - outer_frame_id. */ > + if (memcmp (&l, &r, sizeof (l)) == 0) > + /* Every frame is equal to itself. > + This is the dodgy thing about outer_frame_id, since between execution > + steps we might step into another function - from which we can't unwind > + either. More thought required to get rid of outer_frame_id. */ > eq = 1; > else if (!l.stack_addr_p || !r.stack_addr_p) > /* Like a NaN, if either ID is invalid, the result is false. > diff --git a/gdb/frame.h b/gdb/frame.h > index 3302645..29c3d16 100644 > --- a/gdb/frame.h > +++ b/gdb/frame.h > @@ -174,6 +174,12 @@ extern struct frame_id frame_id_build_special (CORE_ADDR stack_addr, > as the special identifier address are set to indicate wild cards. */ > extern struct frame_id frame_id_build_wild (CORE_ADDR stack_addr); > > +/* Construct an artificial frame ID. The first parameter is the frame's > + constant code address (typically the entry point), and the second the > + frame's special identifier address. */ > +extern struct frame_id frame_id_build_artificial (CORE_ADDR code_addr, > + CORE_ADDR special_addr); > + > /* Returns non-zero when L is a valid frame (a valid frame has a > non-zero .base). The outermost frame is valid even without an > ID. */ > -- Pedro Alves