From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22579 invoked by alias); 11 Dec 2013 12:16:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22567 invoked by uid 89); 11 Dec 2013 12:16:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2013 12:16:06 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBBCFwqf009434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 11 Dec 2013 07:15:58 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBBCFt6U029896; Wed, 11 Dec 2013 07:15:57 -0500 Message-ID: <52A8577B.8030705@redhat.com> Date: Wed, 11 Dec 2013 12:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Metzger CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [patch v7 03/24] gdbarch: add instruction predicate methods References: <1385735899-12481-1-git-send-email-markus.t.metzger@intel.com> <1385735899-12481-4-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1385735899-12481-4-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00423.txt.bz2 On 11/29/2013 02:37 PM, Markus Metzger wrote: > Add new methods to gdbarch for analyzing the instruction at a given address. > Implement those methods for i386 and amd64 architectures. "This is needed because ." > > 2013-11-29 Markus Metzger > > * amd64-tdep.c (amd64_classify_insn_at, amd64_insn_is_call, > amd64_insn_is_ret, amd64_insn_is_jump, amd64_jmp_p): New. > (amd64_init_abi): Add insn_is_call, insn_is_ret, and insn_is_jump > to gdbarch. > * i386-tdep.c (i386_insn_is_call, i386_insn_is_ret, > i386_insn_is_jump, i386_jmp_p): New. > (i386_gdbarch_init): Add insn_is_call, insn_is_ret, and > insn_is_jump to gdbarch. > * gdbarch.sh (insn_is_call, insn_is_ret, insn_is_jump): New. > * gdbarch.h: Regenerated. > * gdbarch.c: Regenerated. > * arch-utils.h (default_insn_is_call, default_insn_is_ret, > default_insn_is_jump): New. > * arch-utils.c (default_insn_is_call, default_insn_is_ret, > default_insn_is_jump): New. > > +/* Classify the instruction at ADDR using PRED. > + Throw an error if the memory can't be read. */ > + > +static int > +amd64_classify_insn_at (struct gdbarch *gdbarch, CORE_ADDR addr, > + int (*pred) (const struct amd64_insn *)) > +{ > + struct amd64_insn details; > + gdb_byte *buf; > + int len, classification; > + > + len = gdbarch_max_insn_length (gdbarch); > + buf = alloca (len); > + > + read_memory (addr, buf, len); This can be read_code now. -- Pedro Alves