From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12688 invoked by alias); 10 Dec 2013 16:26:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12679 invoked by uid 89); 10 Dec 2013 16:26:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Dec 2013 16:26:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBAGQ8o0030345 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Dec 2013 11:26:09 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBAGQ6vI008195; Tue, 10 Dec 2013 11:26:07 -0500 Message-ID: <52A7409D.8080109@redhat.com> Date: Tue, 10 Dec 2013 16:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Burgess CC: "gdb-patches@sourceware.org" Subject: Re: Call get_compiler_info before test_compiler_info. References: <52A728A0.1050208@broadcom.com> <52A72C70.5040305@redhat.com> <52A7303B.2080901@broadcom.com> <52A737EE.80800@redhat.com> <52A73CE2.60002@broadcom.com> In-Reply-To: <52A73CE2.60002@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00380.txt.bz2 On 12/10/2013 04:10 PM, Andrew Burgess wrote: > On 10/12/2013 3:49 PM, Pedro Alves wrote: >> On 12/10/2013 03:16 PM, Andrew Burgess wrote: >>> On 10/12/2013 3:00 PM, Pedro Alves wrote: >> >>> @@ -2027,10 +2027,6 @@ gdb_caching_proc skip_altivec_tests { >>> >>> # Make sure we have a compiler that understands altivec. >>> set compile_flags {debug nowarnings} >>> - if [get_compiler_info] { >>> - warning "Could not get compiler info" >>> - return 1 >>> - } >>> if [test_compiler_info gcc*] { >>> set compile_flags "$compile_flags additional_flags=-maltivec" >>> } elseif [test_compiler_info xlc*] { >> >> Before, the removed get_compiler_info would always overwrite >> whatever was in the compiler_info before. Now, if the previous >> call to get_compiler_info happened to get an $arg, >> test_compiler_info will now reuse the wrong compiler_info. > > OK, I see. Here's a simpler solution that just adds the missing > call to get_compiler_info. > > The example I found where this is an issue was: gdb.trace/pending.exp, > which pre-patch fails to build for me (when I run just that test), but > after the patch does run. There are probably other examples around. > > OK to apply? OK, but please update the proc's intro comment: # Build a shared library from SOURCES. You must use get_compiler_info # first. proc gdb_compile_shlib {sources dest options} { -- Pedro Alves