From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15183 invoked by alias); 8 Dec 2013 14:18:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15171 invoked by uid 89); 8 Dec 2013 14:18:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Dec 2013 14:18:52 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VpfBs-0000Ln-Nz from Hui_Zhu@mentor.com ; Sun, 08 Dec 2013 06:18:36 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 8 Dec 2013 06:18:36 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Sun, 8 Dec 2013 06:17:58 -0800 Message-ID: <52A47FB9.2030407@mentor.com> Date: Sun, 08 Dec 2013 14:18:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Doug Evans CC: Pedro Alves , gdb-patches ml Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet References: <5265022F.8060203@mentor.com> <52654A2C.9010202@redhat.com> <529707C7.4040504@mentor.com> <5298AE7C.6020607@redhat.com> <529C80D2.2080608@mentor.com> <529C9B42.20600@redhat.com> <529D62F7.80701@mentor.com> <52A22582.8040509@redhat.com> <52A40015.207@mentor.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00304.txt.bz2 On 12/08/13 16:34, Doug Evans wrote: > On Sat, Dec 7, 2013 at 9:13 PM, Hui Zhu wrote: >> 2013-12-08 Hui Zhu >> >> PR gdb/16101 >> * breakpoint.c (insert_bp_location): Change hw_bp_err_string to >> bp_err_string. >> >> Output error message of software breakpoints. >> Make solib error message output use same code with hardware >> breakpoints and software breakpoints. >> >> * remote.c (remote_insert_breakpoint): If this breakpoint has >> target-side commands but this stub doesn't support Z0 packets, >> throw error. > > Nit. This changelog is badly formatted. > Please fix. > > I suspect, though this is only based on perusal of the patch, > and not close analysis, that you meant to write: > > PR gdb/16101 > * breakpoint.c (insert_bp_location): Change hw_bp_err_string to > bp_err_string. Output error message of software breakpoints. > Make solib error message output use same code with hardware > breakpoints and software breakpoints. > > * remote.c (remote_insert_breakpoint): If this breakpoint has > target-side commands but this stub doesn't support Z0 packets, > throw error. > Thanks for your remind. 2013-12-08 Hui Zhu PR gdb/16101 * breakpoint.c (insert_bp_location): Change hw_bp_err_string to bp_err_string. Output error message of software breakpoints. Make solib error message output use same code with hardware breakpoints and software breakpoints. * remote.c (remote_insert_breakpoint): If this breakpoint has target-side commands but this stub doesn't support Z0 packets, throw error. > [I may have gotten the indentation wrong, cut-n-paste in gmail, blech. > The point is the blank line before "Output error ..." is wrong. ISTM.] > I got some indentation issue with web gmail in a few weeks ago. But this time it looks OK in my part. I think they has fixed the issue. Thanks, Hui