From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108040-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9060 invoked by alias); 6 Dec 2013 13:30:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9049 invoked by uid 89); 6 Dec 2013 13:30:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO: mail-gw2-out.broadcom.com
Received: from Unknown (HELO mail-gw2-out.broadcom.com) (216.31.210.63) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Dec 2013 13:30:36 +0000
Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57])  by mail-gw2-out.broadcom.com with ESMTP; 06 Dec 2013 05:34:56 -0800
Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Fri, 6 Dec 2013 05:30:25 -0800
Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Fri, 6 Dec 2013 05:30:25 -0800
Received: from [10.177.73.48] (unknown [10.177.73.48])	by mail-irva-13.broadcom.com (Postfix) with ESMTP id B1E98246A5	for <gdb-patches@sourceware.org>; Fri,  6 Dec 2013 05:30:24 -0800 (PST)
Message-ID: <52A1D16F.3090207@broadcom.com>
Date: Fri, 06 Dec 2013 13:30:00 -0000
From: Andrew Burgess <aburgess@broadcom.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.1
MIME-Version: 1.0
To: <gdb-patches@sourceware.org>
Subject: Re: [PATCH [1/2] Add support for DW_OP_bit_piece and DW_OP_plus_uconst to DWARF assembler.
References: <529F489F.7070805@broadcom.com> <529F493C.8090201@broadcom.com> <52A0A87B.30100@redhat.com> <87ob4vnn87.fsf@fleche.redhat.com>
In-Reply-To: <87ob4vnn87.fsf@fleche.redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2013-12/txt/msg00244.txt.bz2

On 05/12/2013 6:53 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
>>> DW_OP_plus_uconst.
> 
> Pedro> Looks fine to me, but Tromey may want to take a look.
> 
> It's good.  Thanks Andrew.

Thanks for the review.  Pushed with the patches that Pedro pointed out.

Andrew