From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20422 invoked by alias); 6 Dec 2013 12:57:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20409 invoked by uid 89); 6 Dec 2013 12:57:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Dec 2013 12:57:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB6CuoTs013785 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Dec 2013 07:56:51 -0500 Received: from localhost.localdomain (ovpn-112-40.ams2.redhat.com [10.36.112.40]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rB6CumjL023635; Fri, 6 Dec 2013 07:56:49 -0500 Message-ID: <52A1C990.1010703@redhat.com> Date: Fri, 06 Dec 2013 12:57:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Doug Evans , "gdb-patches@sourceware.org" Subject: Re: [PATCH 00/13] script language API for GDB References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00243.txt.bz2 On 06/12/13 05:51, Doug Evans wrote: > Ok, let's try this again. > > On Thu, Dec 5, 2013 at 9:05 AM, Doug Evans wrote: >> Hi. >> >> My patch set to add a scripting API to GDB is ready for submission. >> It sets things up so that adding Guile scripting is straightforward. >> I've cc'd guile-users to apprise them of my progress. >> I'll spare them the actual set of patches here, >> though I plan to cc them when submitting the Guile port, >> their input will be helpful. >> The actual Guile port is ready ... just have some more docs to write. :-) Thanks I reviewed the series. Most comments are inline. I will do a summary here. More documentation. The API implementer really needs to know about what they have to really implement over what is optional. An addition to the internals manual would be super. At the very least far more comments in the structures. Scripting language priority needs to be looked at in certain situations. I documented my thoughts in-line. But as I presume each scripting language keeps its own meta-data, (IE printer lists), we will have to refactor the "info frame-filter/type-printer/pretty-printer" commands to work with all of them. Internal naming nits. A few comments on some breakpoint struct changes. Cheers, Phil