From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27261 invoked by alias); 6 Dec 2013 09:43:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27251 invoked by uid 89); 6 Dec 2013 09:43:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Dec 2013 09:43:26 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB69hHCG001717 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Dec 2013 04:43:17 -0500 Received: from localhost.localdomain (ovpn-112-40.ams2.redhat.com [10.36.112.40]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rB69hGwO012509; Fri, 6 Dec 2013 04:43:17 -0500 Message-ID: <52A19C34.3050206@redhat.com> Date: Fri, 06 Dec 2013 09:43:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: xdje42@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH v1 03/13] script language API for GDB: python.[ch] changes References: <52a1662d.a601430a.7cf1.61b3@mx.google.com> In-Reply-To: <52a1662d.a601430a.7cf1.61b3@mx.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00239.txt.bz2 On 06/12/13 05:52, xdje42@gmail.com wrote: > This patch contains the changes to python-internal.h, python.c, python.h. > It defines the "ops" vectors for Python, defines script_language_python > as the top level interface to Python, and then has a bunch of renamings. > The functions that implement the script_language_ops "methods" are all > named ${lang}_${method_name}. > Functions that were exported to gdb now live in the ops vectors. Thanks, I am reviewing these today. But, just a quick note. > @@ -1815,8 +1851,29 @@ finish_python_initialization (void) > do_cleanups (cleanup); > } > > +/* Return non-zero if Python has successfully initialized. > + This is the script_languages_ops.initialized "method". */ > + > +static int > +gdbpy_initialized (const struct script_language_defn *slang) > +{ > + return gdb_python_initialized; > +} > + > #endif /* HAVE_PYTHON */ > > +/* Some code (e.g., MI) wants to know if a particular scripting language > + successfully initialized. > + Return non-zero if Python scripting successfully initialized. */ > + > +int > +script_lang_python_initialized (void) > +{ > + if (script_language_python.ops != NULL) > + return script_language_python.ops->initialized (&script_language_python); > + return 0; > +} > + This hunk was rejected via patch. All the other patches and hunks in all the other mails were fine, so weird. Anyway just thought I would note it, you might need to do a git pull. Or maybe the ^L's got mangled by the mailer or something. Cheers, Phil