Re: PATCH [0/2] Convert unavailable vector to be bit, not byte, based.

Doug Evans
2013-12-05T18:14:12Z

On Thu, Dec 5, 2013 at 8:17 AM, Pedro Alves <palves@redhat.com> wrote:
> On 12/04/2013 03:22 PM, Andrew Burgess wrote:
>> This patch set is inspired by two previous patches I've posted:
>>
>> https://sourceware.org/ml/gdb-patches/2013-08/msg00305.html
>> https://sourceware.org/ml/gdb-patches/2013-08/msg00309.html
>>
>> but I think can exist as a separate piece of work.
>
> Excellent! The new test is quite nice work.
>
>> The vector of unavailable parts of a value is currently byte based.
>> Given that we can model a value down to the bit level, we can
>> potentially loose information with the current implementation. After
>> the patch we model the unavailable information in bits.
>
> It'd be good if this paragraph ended up in the commit log of patch 2.

I'd prefer a comment in the code too fwiw.
[and then if one still wants to add a comment to the commit log, go for it]
A simple one-liner explaining why things are the way they are would be
sufficient.