From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23632 invoked by alias); 5 Dec 2013 16:18:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23619 invoked by uid 89); 5 Dec 2013 16:18:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2013 16:18:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB5GHwIF003910 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 5 Dec 2013 11:17:58 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rB5GHtSx024971; Thu, 5 Dec 2013 11:17:57 -0500 Message-ID: <52A0A733.3050001@redhat.com> Date: Thu, 05 Dec 2013 16:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Burgess CC: "gdb-patches@sourceware.org" Subject: Re: PATCH [0/2] Convert unavailable vector to be bit, not byte, based. References: <529F489F.7070805@broadcom.com> In-Reply-To: <529F489F.7070805@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00186.txt.bz2 On 12/04/2013 03:22 PM, Andrew Burgess wrote: > This patch set is inspired by two previous patches I've posted: > > https://sourceware.org/ml/gdb-patches/2013-08/msg00305.html > https://sourceware.org/ml/gdb-patches/2013-08/msg00309.html > > but I think can exist as a separate piece of work. Excellent! The new test is quite nice work. > The vector of unavailable parts of a value is currently byte based. > Given that we can model a value down to the bit level, we can > potentially loose information with the current implementation. After > the patch we model the unavailable information in bits. It'd be good if this paragraph ended up in the commit log of patch 2. > > Tested on x86-64 linux, including against native gdbserver. This too. > > Thanks, > Andrew -- Pedro Alves