Re: [PATCH 2/3] skip_prolgoue (amd64)

Pedro Alves
2013-12-03T18:28:16Z

On 12/02/2013 07:32 AM, Yao Qi wrote:
> On 11/30/2013 06:11 PM, Pedro Alves wrote:

>> I'm thinking we might need to flush the dcache before handling each
>> event, like we already invalidate the overlay cache (see
>> "overlay_cache_invalid = 1" in infrun.c) ?
>
> I don't know why overlay cache is flushed in each event. Doing some
> archaeology doesn't give me any clue. I doubt that the overly may
> change between any two events. It (flushing overlay cache) looks not
> necessary to me, at least, when overlay events breakpoint is enabled.

Even with overlay events breakpoint enabled, I'd think we'd want to
be careful to not hit the previous cache even _while_ handling
the overlay breakpoint event. Also, with multi-threading, the
overlay breakpoint event may trigger at the same time as some
other event in another thread, and we may end up handling
the other event first.

--
Pedro Alves