From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28373 invoked by alias); 2 Dec 2013 14:53:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28362 invoked by uid 89); 2 Dec 2013 14:53:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Dec 2013 14:53:02 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB2Eqpu8026489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 Dec 2013 09:52:51 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rB2EqnJp019085; Mon, 2 Dec 2013 09:52:50 -0500 Message-ID: <529C9EC1.2040607@redhat.com> Date: Mon, 02 Dec 2013 14:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [RFA 1/2] New GDB/MI command "-info-gdb-mi-command" References: <528631F2.40408@redhat.com> <1384794719-20594-1-git-send-email-brobecker@adacore.com> <1384794719-20594-2-git-send-email-brobecker@adacore.com> <83y54lfwrm.fsf@gnu.org> <20131119041022.GF3481@adacore.com> In-Reply-To: <20131119041022.GF3481@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00038.txt.bz2 On 11/19/2013 04:10 AM, Joel Brobecker wrote: > Updated patch attached. And for review convenience, I am also attaching > a diff of the changes I made on top of path #1 (to get to the updated > patch). > > gdb/ChangeLog: > > * mi/mi-cmds.h (mi_cmd_info_gdb_mi_command): Declare. > * mi/mi-cmd-info.c (mi_cmd_info_gdb_mi_command): New function. > * mi/mi-cmds.c (mi_cmds): Add -info-gdb-mi-command command. > * mi/mi-main.c (mi_cmd_list_features): Add "info-gdb-mi-command" > field to output of "-list-features". > > * NEWS: Add entry for new -info-gdb-mi-command. > > gdb/doc/ChangeLog: > > * gdb.texinfo (GDB/MI Miscellaneous Commands): Document > the new -info-gdb-mi-command GDB/MI command. Document > the meaning of "-info-gdb-mi-command" in the output of > -list-features. > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-i-cmd.exp: New file. > > Re-tested on x86_64-linux. OK to commit? > Looks fine to me. (I don't have a strong opinion about the dash issue.) > +# First, verify that the debugger correctly advertises support > +# for the -info-gdb-mi-command command. > +mi_gdb_test "-list-features" \ > + "\\^done,features=\\\[.*\"info-gdb-mi-command\".*\\\]" \ > + "-list-features should include \"info-gdb-mi-command\"" Nit, I'd suggest: "-list-features includes \"info-gdb-mi-command\"" -- Pedro Alves