From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9245 invoked by alias); 2 Dec 2013 11:12:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9232 invoked by uid 89); 2 Dec 2013 11:12:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Dec 2013 11:12:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB2BCDRb026678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 Dec 2013 06:12:14 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rB2BCCHM030252; Mon, 2 Dec 2013 06:12:12 -0500 Message-ID: <529C6B0B.1080903@redhat.com> Date: Mon, 02 Dec 2013 11:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: Doug Evans , gdb-patches@sourceware.org Subject: Re: [PATCH] Delegate to target_ops->beneath to read cache lines References: <1385554824-7159-1-git-send-email-yao@codesourcery.com> <5295F877.3060004@redhat.com> <52980180.1050000@codesourcery.com> <529C232A.7080900@codesourcery.com> <529C62B0.1030402@redhat.com> <529C68C9.10001@codesourcery.com> In-Reply-To: <529C68C9.10001@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00031.txt.bz2 On 12/02/2013 11:02 AM, Yao Qi wrote: > On 12/02/2013 06:36 PM, Pedro Alves wrote: >> Do you see a problem with this? >> > > No. Thanks. I pushed it in (...) >> gdb/ >> 2013-12-02 Pedro Alves >> >> * dcache.c (dcache_read_line): Use target_read_raw_memory. >> * target.c (target_read_raw_memory): New function. >> (target_read_stack, target_write_memory, target_write_raw_memory): >> Update comment. >> (target_read_core): Add comment. > ^^^^^ > target_read_code. (...) with that fixed. -- Pedro Alves