From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix PR remote/15974
Date: Mon, 02 Dec 2013 10:02:00 -0000 [thread overview]
Message-ID: <529C5AC0.3050008@redhat.com> (raw)
In-Reply-To: <529C2B33.20102@codesourcery.com>
On 12/02/2013 06:39 AM, Yao Qi wrote:
> On 11/30/2013 04:57 PM, Pedro Alves wrote:
>> Instead of setting and unsetting NC at each iteration, the "canonical" way
>> for this sort of thing is to check whether the loop ended:
>>
>> - if (nc == NULL)
>> + for (i == ARRAY_SIZE (notifs))
>>
>> And then again, we don't really need NC in the loop. I think
>> this would look cleaner and clearer:
>
> OK, you've fixed that bug :). Pushed it for you.
Thanks.
--
Pedro Alves
prev parent reply other threads:[~2013-12-02 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 5:47 Yao Qi
2013-11-30 10:11 ` Pedro Alves
2013-12-02 6:41 ` Yao Qi
2013-12-02 10:02 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C5AC0.3050008@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox