From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4085 invoked by alias); 30 Nov 2013 09:59:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4072 invoked by uid 89); 30 Nov 2013 09:59:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 30 Nov 2013 09:59:30 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAU9xM6G032660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 30 Nov 2013 04:59:22 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAU9xKSm018872; Sat, 30 Nov 2013 04:59:21 -0500 Message-ID: <5299B6F8.9070800@redhat.com> Date: Sat, 30 Nov 2013 11:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Use target_read_code in skip_prologue (i386) References: <1385735051-27558-1-git-send-email-yao@codesourcery.com> <1385735051-27558-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1385735051-27558-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00958.txt.bz2 On 11/29/2013 02:24 PM, Yao Qi wrote: > This patch uses target_read_code and its variants to read target > memory in the functions related to i386_skip_prologue. (IMO, it'd be nice if relevant part of the '0/3' cover letter ended up in the commit log.) > 2013-11-29 Yao Qi Looks good to me. Minor comments below. > > * corefile.c (read_code): New function. > (read_code_integer): New function. > (read_code_unsigned_integer): New function. > * gdbcore.h (read_code): Declare Missing period. > (read_code_integer): Declare. ... > diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h > index 41bcf1f..8e0847b 100644 > --- a/gdb/gdbcore.h > +++ b/gdb/gdbcore.h > @@ -57,6 +57,10 @@ extern void read_memory (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len); > > extern void read_stack (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len); > > +/* Like target_read_code, but report an error if can't read. */ > + > +extern void read_code (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len); > + > /* Read an integer from debugged memory, given address and number of > bytes. */ > > @@ -73,6 +77,19 @@ extern ULONGEST read_memory_unsigned_integer (CORE_ADDR memaddr, > int len, > enum bfd_endian byte_order); > > +/* Read an integer from debugged code memory, given address and > + number of bytes. */ /* Read an integer from debugged code memory, given address, number of bytes, and byte order for code. */ > + > +extern LONGEST read_code_integer (CORE_ADDR memaddr, int len, > + enum bfd_endian byte_order); > + > +/* Read an unsigned integer from debugged code memory, given address > + and number of bytes. */ Likewise. > + > +extern ULONGEST read_code_unsigned_integer (CORE_ADDR memaddr, > + int len, > + enum bfd_endian byte_order); > + Thanks, -- Pedro Alves