Re: [PATCH] Print entirely unavailable struct/union values as a single . (Re: [PATCH 06/12] Delete value_bits_valid.)

Andrew Burgess
2013-11-26T09:39:33Z

On 25/11/2013 6:49 PM, Pedro Alves wrote:
>
> I'd like to get this part out of the way; I don't have a problem with
> it.
>
> We don't really need the whole series for this though. Any
> objections?

Sounds reasonable to me.

> gdb/
> 2013-11-25 Andrew Burgess <aburgess@broadcom.com>
> Pedro Alves <palves@redhat.com>
>
> * valprint.c (value_check_printable): If the value is entirely
> unavailable, print a single "<unavailable>" instead of printing
> all subfields.
>
> gdb/testsuite/
> 2013-11-25 Andrew Burgess <aburgess@broadcom.com>
>
> * gdb.trace/unavailable.exp(gdb_collect_args_test): Update
> expected results.
> (gdb_collect_locals_test): Likewise.
> (gdb_collect_globals_test): Likewise.

Looks fine to me.

Thanks,
Andrew