From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9458 invoked by alias); 27 Nov 2013 18:14:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9412 invoked by uid 89); 27 Nov 2013 18:14:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2013 18:13:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rARIDqPi003199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Nov 2013 13:13:52 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rARIDoXB031518; Wed, 27 Nov 2013 13:13:51 -0500 Message-ID: <5296365E.3010602@redhat.com> Date: Wed, 27 Nov 2013 18:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Make "set debug frame 1" output print instead of . References: <5208D50F.8020109@broadcom.com> <1385574760-26557-1-git-send-email-palves@redhat.com> <1385574760-26557-3-git-send-email-palves@redhat.com> In-Reply-To: <1385574760-26557-3-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00855.txt.bz2 On 11/27/2013 05:52 PM, Pedro Alves wrote: > struct value * > frame_unwind_got_optimized (struct frame_info *frame, int regnum) > { > - struct gdbarch *gdbarch = frame_unwind_arch (frame); > - struct type *reg_type = register_type (gdbarch, regnum); Oh, wait. Given multi-arch, the arch of FRAME might be different from the prev frame's arch, and therefore the type of register REGNUM should be retrieved from the unwound arch. > + struct value *val; > > - return allocate_optimized_out_value (reg_type); > + val = value_of_register_lazy (frame, regnum); This is using the type of REGNUM in FRAME. I'll fix this in a moment... > + set_value_lazy (val, 0); > + set_value_optimized_out (val, 1); > + return val; -- Pedro Alves