From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107656-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27427 invoked by alias); 26 Nov 2013 16:38:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27416 invoked by uid 89); 26 Nov 2013 16:38:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2
X-HELO: mms1.broadcom.com
Received: from Unknown (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2013 16:38:43 +0000
Received: from [10.9.208.55] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Tue, 26 Nov 2013 08:38:12 -0800
X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261
Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS07.corp.ad.broadcom.com (10.9.208.55) with Microsoft SMTP Server (TLS) id 14.1.438.0; Tue, 26 Nov 2013 08:38:28 -0800
Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Tue, 26 Nov 2013 08:38:28 -0800
Received: from [10.177.73.71] (unknown [10.177.73.71]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id DF384246A3; Tue, 26 Nov 2013 08:38:27 -0800 (PST)
Message-ID: <5294CE82.2060107@broadcom.com>
Date: Tue, 26 Nov 2013 21:14:00 -0000
From: "Andrew Burgess" <aburgess@broadcom.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.1
MIME-Version: 1.0
To: "Pedro Alves" <palves@redhat.com>
cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Tighten regexp in gdb.base/setshow.exp
References: <5294C81D.2070903@broadcom.com> <5294C8FB.5010700@redhat.com>
In-Reply-To: <5294C8FB.5010700@redhat.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2013-11/txt/msg00823.txt.bz2

On 26/11/2013 4:14 PM, Pedro Alves wrote:
> On 11/26/2013 04:11 PM, Andrew Burgess wrote:
>>
>> 2013-11-26  Andrew Burgess  <aburgess@broadcom.com>
>>
>> 	* gdb.base/setshow.exp: Add $gdb_prompt to the patterns in
>> 	gdb_test_multiple.
> 
> OK, thanks.
> 
>> +    -re "\nHOME = (\[^\n\r\]*)\[\r\n\]+$gdb_prompt $" {
> 
> Any reason to write \n\r instead of the more usual \r\n though ?

No, just my fingers.  I've switched them to "\r\n" in the version
I just pushed.

Thanks,
Andrew