From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25076 invoked by alias); 26 Nov 2013 16:11:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25066 invoked by uid 89); 26 Nov 2013 16:11:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mms1.broadcom.com Received: from Unknown (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2013 16:11:26 +0000 Received: from [10.9.208.57] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Tue, 26 Nov 2013 08:10:55 -0800 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Tue, 26 Nov 2013 08:11:10 -0800 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Tue, 26 Nov 2013 08:11:10 -0800 Received: from [10.177.73.71] (unknown [10.177.73.71]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 5567C246A5 for ; Tue, 26 Nov 2013 08:11:10 -0800 (PST) Message-ID: <5294C81D.2070903@broadcom.com> Date: Tue, 26 Nov 2013 16:28:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [PATCH] Tighten regexp in gdb.base/setshow.exp Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00819.txt.bz2 Had a random test failure in gdb.base/setshow.exp caused by $gdb_prompt not being used on the end of a regexp for gdb_test_multiple. Fixed in the two obvious places. Other uses of gdb_test_multiple in this file are messing with the prompt so I've left them alone. OK to apply? Thanks, Andrew gdb/testsuite/ChangeLog 2013-11-26 Andrew Burgess * gdb.base/setshow.exp: Add $gdb_prompt to the patterns in gdb_test_multiple. diff --git a/gdb/testsuite/gdb.base/setshow.exp b/gdb/testsuite/gdb.base/setshow.exp index d9e71d3..21df262 100644 --- a/gdb/testsuite/gdb.base/setshow.exp +++ b/gdb/testsuite/gdb.base/setshow.exp @@ -169,7 +169,7 @@ gdb_test "show history expansion on" "History expansion on command input is on.* set HOME "" set test "show environment HOME" gdb_test_multiple $test $test { - -re "\nHOME = (.*).\n.*" { + -re "\nHOME = (\[^\n\r\]*)\[\r\n\]+$gdb_prompt $" { set HOME $expect_out(1,string) pass $test } @@ -185,7 +185,7 @@ gdb_test "show history filename" \ set PWD "" set test "show working directory" gdb_test_multiple "pwd" $test { - -re "\nWorking directory (.*)..\n.*" { + -re "\nWorking directory (\[^\n\r\]*)\\.\[\r\n\]+$gdb_prompt $" { set PWD $expect_out(1,string) pass $test }