From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30045 invoked by alias); 26 Nov 2013 09:39:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30034 invoked by uid 89); 26 Nov 2013 09:39:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mms3.broadcom.com Received: from Unknown (HELO mms3.broadcom.com) (216.31.210.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2013 09:39:32 +0000 Received: from [10.9.208.57] by mms3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Tue, 26 Nov 2013 01:38:19 -0800 X-Server-Uuid: B86B6450-0931-4310-942E-F00ED04CA7AF Received: from IRVEXCHSMTP3.corp.ad.broadcom.com (10.9.207.53) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Tue, 26 Nov 2013 01:39:18 -0800 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP3.corp.ad.broadcom.com (10.9.207.53) with Microsoft SMTP Server id 14.1.438.0; Tue, 26 Nov 2013 01:39:18 -0800 Received: from [10.177.73.71] (unknown [10.177.73.71]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id F36FF246A5; Tue, 26 Nov 2013 01:39:17 -0800 (PST) Message-ID: <52946C45.2040003@broadcom.com> Date: Tue, 26 Nov 2013 10:13:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: "Pedro Alves" cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Print entirely unavailable struct/union values as a single . (Re: [PATCH 06/12] Delete value_bits_valid.) References: <5208D1DF.1090201@broadcom.com> <5208D495.9080806@broadcom.com> <52939BD4.4090803@redhat.com> In-Reply-To: <52939BD4.4090803@redhat.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00802.txt.bz2 On 25/11/2013 6:49 PM, Pedro Alves wrote: > > I'd like to get this part out of the way; I don't have a problem with > it. > > We don't really need the whole series for this though. Any > objections? Sounds reasonable to me. > gdb/ > 2013-11-25 Andrew Burgess > Pedro Alves > > * valprint.c (value_check_printable): If the value is entirely > unavailable, print a single "" instead of printing > all subfields. > > gdb/testsuite/ > 2013-11-25 Andrew Burgess > > * gdb.trace/unavailable.exp(gdb_collect_args_test): Update > expected results. > (gdb_collect_locals_test): Likewise. > (gdb_collect_globals_test): Likewise. Looks fine to me. Thanks, Andrew