From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21515 invoked by alias); 25 Nov 2013 15:31:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21505 invoked by uid 89); 25 Nov 2013 15:31:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.1 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mga01.intel.com Received: from Unknown (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2013 15:31:03 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 25 Nov 2013 07:30:55 -0800 X-ExtLoop1: 1 Received: from wtedesch-mobl2.ger.corp.intel.com (HELO [172.28.205.50]) ([172.28.205.50]) by fmsmga002.fm.intel.com with ESMTP; 25 Nov 2013 07:30:54 -0800 Message-ID: <52936D2D.7080500@intel.com> Date: Mon, 25 Nov 2013 15:48:00 -0000 From: Walfred Tedeschi User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Mark Kettenis CC: palves@redhat.com, yao@codesourcery.com, gdb-patches@sourceware.org Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts. References: <1385386802-16948-1-git-send-email-walfred.tedeschi@intel.com> <201311251449.rAPEn6uZ014952@glazunov.sibelius.xs4all.nl> <201311251518.rAPFIgbc010735@glazunov.sibelius.xs4all.nl> In-Reply-To: <201311251518.rAPFIgbc010735@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset="iso-8859-15"; format="flowed" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00783.txt.bz2 Am 11/25/2013 4:18 PM, schrieb Mark Kettenis: >> From: "Tedeschi, Walfred" >> Date: Mon, 25 Nov 2013 14:56:59 +0000 >> >> Hello Mark, >> >> Ok, I Will let it symmetrical to the AVX, i.e: >> >> /* In case one of the MPX XCR0 bits is set we consider we have MPX. >> #define HAS_MPX(XCR0) ((XCR0) & I386_XSTATE_MPX) =3D=3D I386_XSTATE_MPX > Still doesn't do what it says on the tin. The macro is checking if > *both* bits are set. If you want to have the code match the comment > it needs to be changed to something like: > > #define HAS_MPX(XRC0) (((XRC0) & I386_XSTATE_MPX) !=3D 0) > > or you need to change the comment to state that all bits need to be set. Hello Mark, What you proposed is better. I will incorporate your feedback and Pedro's feedback and resend it. Thanks your review and feedback! Regards, -Fred Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052