From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48846 invoked by alias); 11 May 2017 18:14:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48836 invoked by uid 89); 11 May 2017 18:14:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=thursday, treatment X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 May 2017 18:14:49 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 7017110A87D; Thu, 11 May 2017 14:14:49 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Cc: Yao Qi Subject: Re: [RFC 6/7] Lazily and dynamically create i386-linux target descriptions Date: Thu, 11 May 2017 18:14:00 -0000 Message-ID: <5290733.2saQ3BOrGQ@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <1494518105-15412-7-git-send-email-yao.qi@linaro.org> References: <1494518105-15412-1-git-send-email-yao.qi@linaro.org> <1494518105-15412-7-git-send-email-yao.qi@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00298.txt.bz2 On Thursday, May 11, 2017 04:55:04 PM Yao Qi wrote: > Instead of using pre-generated target descriptions, this patch > changes GDB to lazily and dynamically create target descriptions > according to the target hardware capability (xcr0 in i386). > This support any combination of target features. > > This patch also adds a unit test to make sure dynamically generated > tdesc are identical to these generated from xml files. I definitely like this approach of composing the tdesc. For the non-Linux case there are already amd64_target_description() and i386_target_description() functions in the respective -tdep.c files that could use the same treatment. Not sure if you wanted to fix all of x86 in the same patch series or do it as a separate followup? -- John Baldwin