From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19185 invoked by alias); 22 Nov 2013 17:40:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19168 invoked by uid 89); 22 Nov 2013 17:40:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2013 17:40:42 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAMHeZLO029571 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Nov 2013 12:40:35 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAMHeXdS007805; Fri, 22 Nov 2013 12:40:34 -0500 Message-ID: <528F9711.1000208@redhat.com> Date: Fri, 22 Nov 2013 17:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] avoid infinite loop with bad debuginfo References: <1384375873-32160-1-git-send-email-tromey@redhat.com> <1384375873-32160-2-git-send-email-tromey@redhat.com> <52850730.1060109@redhat.com> <87d2lxpo1l.fsf@fleche.redhat.com> <528F6AC0.6020509@redhat.com> <87zjowcqnq.fsf@fleche.redhat.com> In-Reply-To: <87zjowcqnq.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00693.txt.bz2 On 11/22/2013 05:06 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Tom> Barf. I have a memory of actually writing that. False memory I guess. > Tom> Sigh. > > Pedro> Don't sigh. :-) I now believe the regnum check would be wrong. > > Haha, then it is double wrong, since I thought I wrote it that way :) :-) > Pedro> This shouldn't return any register of the same frame. > > Pedro> WDYT of adjusting the patch like this? > > It looks good to me. Please put it in. Pushed. > I tried current git master with my original test case and I see it is > fixed. So, thanks :) Awesome! -- Pedro Alves