From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107441-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16455 invoked by alias); 20 Nov 2013 19:19:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16426 invoked by uid 89); 20 Nov 2013 19:19:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_05,RDNS_NONE,SPF_HELO_PASS autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Nov 2013 19:18:04 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAKJHs59000753	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 20 Nov 2013 14:17:55 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAKJHqTD023685;	Wed, 20 Nov 2013 14:17:53 -0500
Message-ID: <528D0AE0.50702@redhat.com>
Date: Wed, 20 Nov 2013 20:01:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: "Maciej W. Rozycki" <macro@codesourcery.com>
CC: gdb-patches@sourceware.org, Stan Shebs <stan@codesourcery.com>
Subject: Re: [PATCH] gdb.mi/mi-info-os.exp: Fix cross-debugger testing
References: <alpine.DEB.1.10.1311010106300.12843@tp.orcam.me.uk>
In-Reply-To: <alpine.DEB.1.10.1311010106300.12843@tp.orcam.me.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-11/txt/msg00608.txt.bz2

On 11/01/2013 01:16 AM, Maciej W. Rozycki wrote:

> gdb-test-mi-info-os.diff
> Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.mi/mi-info-os.exp
> ===================================================================
> --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.mi/mi-info-os.exp	2013-11-01 00:52:48.000000000 +0000
> +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.mi/mi-info-os.exp	2013-11-01 00:56:43.588756235 +0000
> @@ -33,6 +33,20 @@ if [mi_gdb_start] {
>      continue
>  }
>  
> +# In non-native configurations we need to have a live target.
> +if { ![isnative] } {

Shouldn't this be [is_remote target] ?  isnative just compares
the _build_ and target triplets.

(And even if host and target triplets matched, we could still
have a configuration without a native target)

Otherwise OK.

> +    standard_testfile basics.c
> +
> +    if [build_executable "Failed to build $testfile" $testfile $srcfile \
> +	debug] {
> +	return -1;
> +    }
> +
> +    if {[mi_run_to_main] < 0} {
> +	return -1
> +    }
> +}
> +
>  # Try the argument-less form that lists all the types in a table.
>  
>  mi_gdb_test "-info-os" ".*\\^done,OSDataTable=.*" "-info-os"
> 


-- 
Pedro Alves