From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32752 invoked by alias); 19 Nov 2013 17:05:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32728 invoked by uid 89); 19 Nov 2013 17:05:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2013 17:05:49 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJH5c0D006889 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 19 Nov 2013 12:05:38 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAJH5ZFx022929; Tue, 19 Nov 2013 12:05:36 -0500 Message-ID: <528B9A5F.5020706@redhat.com> Date: Tue, 19 Nov 2013 17:08:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Agovic, Sanimir" CC: "'Tom Tromey'" , "gdb-patches@sourceware.org" Subject: Re: [PATCH 05/10] vla: allow side effects for sizeof argument References: <1382366424-21010-1-git-send-email-sanimir.agovic@intel.com> <1382366424-21010-6-git-send-email-sanimir.agovic@intel.com> <87d2mua1gi.fsf@fleche.redhat.com> <0377C58828D86C4588AEEC42FC3B85A71769F292@IRSMSX105.ger.corp.intel.com> <87ppqp9kme.fsf@fleche.redhat.com> <0377C58828D86C4588AEEC42FC3B85A7176B5F16@IRSMSX105.ger.corp.intel.com> In-Reply-To: <0377C58828D86C4588AEEC42FC3B85A7176B5F16@IRSMSX105.ger.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00554.txt.bz2 On 11/18/2013 08:39 AM, Agovic, Sanimir wrote: > > It turns out this patch is not needed anymore as the bounds are resolved > before the sizeof function is called. So in v2 this patch will be dropped > from the series. > >> > (gdb) print sizeof (array[x++]) >> > >> > For an ordinary array this should not modify x. > Indeed, that is the behavior we have now in HEAD@vla-c99. Sounds like something that the testsuite should have caught. I guess we don't have such a test? -- Pedro Alves