From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25102 invoked by alias); 19 Nov 2013 15:10:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25074 invoked by uid 89); 19 Nov 2013 15:10:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2013 15:10:03 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJF9qhh016404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 19 Nov 2013 10:09:53 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAJF9ooD016636; Tue, 19 Nov 2013 10:09:51 -0500 Message-ID: <528B7F3E.1040700@redhat.com> Date: Tue, 19 Nov 2013 15:14:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Walfred Tedeschi CC: tromey@redhat.com, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org Subject: Re: [PATCH V7 5/8] Add MPX support to gdbserver. References: <1381320034-4092-1-git-send-email-walfred.tedeschi@intel.com> <1381320034-4092-6-git-send-email-walfred.tedeschi@intel.com> In-Reply-To: <1381320034-4092-6-git-send-email-walfred.tedeschi@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00541.txt.bz2 (Huh, I thought I had pushed the send button for this yesterday, but turns out I didn't.) On 10/09/2013 01:00 PM, Walfred Tedeschi wrote: > 2013-05-22 Walfred Tedeschi > > gdbserver/ > * Makefile.in: Add i386-mpx.c, i386-mpx-linux.c, amd64-mpx.c, > amd64-mpx-linux.c, x32-mpx.c and x32-mpx-linux.c generation. > > * configure.srv (srv_i386_regobj): Add i386-mpx.o. > (srv_i386_linux_regobj): Add i386-mpx-linux.o. > (srv_amd64_regobj): Add amd64-mpx.o. > (srv_amd64_linux_regobj): Add amd64-mpx-linux.o. > (srv_i386_32bit_xmlfiles): Add i386/32bit-mpx.xml. > (srv_i386_64bit_xmlfiles): Add i386/64bit-mpx.xml. > > * i387-fp.c (num_pl_bnd_register) Added constant. > (num_pl_bnd_cfg_registers) Added constant. > (struct i387_xsave) Added reserved area and MPX fields. > (i387_cache_to_xsave, i387_xsave_to_cache) Add MPX. > > * linux-x86-low.c (init_registers_i386_mpx_linux): Declare new > function. > (tdesc_i386_mpx_linux): Add MPX amd64 target. > (init_registers_amd64_mpx_linux): Declare new function. > (tdesc_amd64_mpx_linux): Add MPX amd64 target. > (init_registers_x32_mpx_linux): Declare new function. > (tdesc_x32_mpx_linux): Add MPX amd64 target. > (x86_64_regmap): Add MPX registers. > (x86_linux_read_description): Add MPX case. > (initialize_low_arch): Initialize MPX targets. FWIW, this looks fine from a add-new-port-to-gdbserver perspective. -- Pedro Alves