From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21972 invoked by alias); 19 Nov 2013 11:13:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21961 invoked by uid 89); 19 Nov 2013 11:13:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2013 11:13:41 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJBDW7O015340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 19 Nov 2013 06:13:32 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAJBDU3v002622; Tue, 19 Nov 2013 06:13:31 -0500 Message-ID: <528B47DA.2070300@redhat.com> Date: Tue, 19 Nov 2013 11:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Add "undefined-command" error code at end of ^error result... References: <528631F2.40408@redhat.com> <1384794719-20594-1-git-send-email-brobecker@adacore.com> <1384794719-20594-3-git-send-email-brobecker@adacore.com> In-Reply-To: <1384794719-20594-3-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00522.txt.bz2 On 11/18/2013 05:11 PM, Joel Brobecker wrote: > gdb/ChangeLog: > > (from Pedro Alves ) > (from Joel Brobecker ) > * exceptions.h (enum_errors) : New enum. > * mi/mi-parse.c (mi_parse): Thow UNKNOWN_COMMAND_ERROR instead "Throw" > of a regular error when the GDB/MI command does not exist. > * mi/mi-main.c (mi_cmd_list_features): Add > "undefined-command-error-code". > (mi_print_exception): Print an "undefined-command" > error code if EXCEPTION.ERROR in UNKNOWN_COMMAND_ERROR. s/in/is ? > * NEWS: Add entry documenting the new "code" variable in > "^error" result records. > > gdb/doc/ChangeLog: > > * gdb.texinfo (GDB/MI Result Records): Fix the syntax of the > "^error" result record concerning the error message. Document > the error code that may also be part of that result record. > (GDB/MI Miscellaneous Commands): Document the > "undefined-command-error-code" element in the output of > the "-list-features" GDB/MI command. > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-undefined-cmd.exp: New testcase. > > Tested on x86_64-linux. OK to commit? Looks good to me... > (hmmm, now that I have spent all that time typing everything up, > I am wondering if I should rename UNKNOWN_COMMAND_ERROR into > UNDEFINED_COMMAND_ERROR - no real biggie either way...) Yeah, I think so. The CLI also says "undefined": (gdb) asdf Undefined command: "asdf". Try "help". Might as well be consistent throughout. -- Pedro Alves