From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8434 invoked by alias); 18 Nov 2013 18:17:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8370 invoked by uid 89); 18 Nov 2013 18:17:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_05,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2013 18:16:33 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAIIGQY4013906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 18 Nov 2013 13:16:26 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAIIGOx3003115; Mon, 18 Nov 2013 13:16:25 -0500 Message-ID: <528A5978.6000000@redhat.com> Date: Mon, 18 Nov 2013 18:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 02/16] change how list of modules is computed References: <1383757800-6332-1-git-send-email-tromey@redhat.com> <1383757800-6332-3-git-send-email-tromey@redhat.com> In-Reply-To: <1383757800-6332-3-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00484.txt.bz2 On 11/06/2013 05:09 PM, Tom Tromey wrote: > While adding modules I found that the current approach of listing all > the modules on one line made it harder to experiment -- any conflicts > from git were a pain to resolve. > > This patch splits the list of modules so that there is one module per > line. > > 2013-11-06 Tom Tromey > > * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Split into > multiple lines. > --- > gdb/ChangeLog | 5 +++++ > gdb/gnulib/update-gnulib.sh | 9 ++++++++- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/gdb/gnulib/update-gnulib.sh b/gdb/gnulib/update-gnulib.sh > index 0b292ba..3a8502c 100644 > --- a/gdb/gnulib/update-gnulib.sh > +++ b/gdb/gnulib/update-gnulib.sh > @@ -29,7 +29,14 @@ > # regenerate the various scripts and Makefiles are on the PATH. > > # The list of gnulib modules we are importing in GDB. > -IMPORTED_GNULIB_MODULES="fnmatch-gnu frexpl inttypes memmem update-copyright unistd pathmax" > +IMPORTED_GNULIB_MODULES="" > +IMPORTED_GNULIB_MODULES="$IMPORTED_GNULIB_MODULES fnmatch-gnu" > +IMPORTED_GNULIB_MODULES="$IMPORTED_GNULIB_MODULES frexpl" > +IMPORTED_GNULIB_MODULES="$IMPORTED_GNULIB_MODULES inttypes" > +IMPORTED_GNULIB_MODULES="$IMPORTED_GNULIB_MODULES memmem" > +IMPORTED_GNULIB_MODULES="$IMPORTED_GNULIB_MODULES update-copyright" > +IMPORTED_GNULIB_MODULES="$IMPORTED_GNULIB_MODULES unistd" > +IMPORTED_GNULIB_MODULES="$IMPORTED_GNULIB_MODULES pathmax" > Wouldn't using continuation lines work just as well? -IMPORTED_GNULIB_MODULES="fnmatch-gnu frexpl inttypes memmem update-copyright unistd pathmax" +IMPORTED_GNULIB_MODULES="\ + fnmatch-gnu \ + frexpl \ + inttypes \ + memmem \ + update-copyright \ + unistd \ + pathmax \ +" I'd find that a lot less distracting, therefore more readable. -- Pedro Alves