From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23991 invoked by alias); 18 Nov 2013 15:56:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23960 invoked by uid 89); 18 Nov 2013 15:56:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2013 15:56:48 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAIFudSH027330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 18 Nov 2013 10:56:40 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAIFubw8000395; Mon, 18 Nov 2013 10:56:38 -0500 Message-ID: <528A38B5.6020906@redhat.com> Date: Mon, 18 Nov 2013 15:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 05/10] Invalidate or shrink dcache when setting is changed. References: <1383458049-20893-1-git-send-email-yao@codesourcery.com> <1383458049-20893-6-git-send-email-yao@codesourcery.com> In-Reply-To: <1383458049-20893-6-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00472.txt.bz2 On 11/03/2013 05:54 AM, Yao Qi wrote: > Nowadays, when cache size or line size is changed by command, > 'target_dcache' is invalidated. It is too conservative. We can > optimize in the following ways, > > - Don't have to invalidate dcache immediately after cache size or > line size is changed. We can postpone the invalidation to the moment > using 'target_dcache'. > - Don't have to invalidate dcache if the cache size is changed. If > cache size is changed to the value which is still greater than > dcache's size, nothing should be done. If change to the value > which is less than dcache's size, just evict cache lines. > > This is what this patch does. Actually, my "My thoughts exactly." comment in the other patch was originally directed at this patch. Do we really need this extra complication? What's the use case that needs this? -- Pedro Alves