Re: [PATCH v4 3/9] add target method delegation

Tom Tromey
2013-12-18T22:06:47Z

Pedro> Yeah, not sure either... squash a few; post only the non-trivial
Pedro> ones as email; post all of them at once anyway; split in 4 or
Pedro> 5 batches. Whatever really is fine with me.

In case you want to see my progress, I've pushed the current branch to
my gitorious repository:

git@gitorious.org:binutils-gdb/gdb.git

The branch is "target-cleanup".

I've built the branch but barely tested it. I'm sure it breaks in some
configurations -- the fixes are trivial but I did have to do a number of
them as my refactoring script, while fun, could not perfectly fix
everything.

Aside from a few patches at the beginning of the series I think it's all
split and ordered pretty much as I'd like it to be.

I converted all the easy target methods to the new inheritance scheme.
This works out to be nearly all of them. There are a few more that
aren't too bad to convert (actually, looking again now I see I missed a
few more easy ones), and then a handful of tricky ones.

It's over the 200 patch mark... not sure I want to write those
ChangeLogs (my refactoring script only did the first 100 or so for
me...) or even re-read them all for sanity.

I hope you will agree that the result is much cleaner. It's simpler to
explain and understand; and it is obvious which model one ought to
choose when adding new target methods. It's also a good setup for the
multi-target work.

Tom