From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27148 invoked by alias); 18 Nov 2013 12:07:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27135 invoked by uid 89); 18 Nov 2013 12:07:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2013 12:07:12 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAIC73dv030078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 18 Nov 2013 07:07:04 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAIC72o7024965; Mon, 18 Nov 2013 07:07:03 -0500 Message-ID: <528A02E5.7070309@redhat.com> Date: Mon, 18 Nov 2013 12:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: [OB] Simplify dwarf2-frame.c:read_addr_from_reg. (was: [RFA] Rename "read_reg" into "read_addr_from_reg" in struct dwarf_expr_context_funcs) References: <5286326C.8010204@redhat.com> <1384573853-25378-1-git-send-email-brobecker@adacore.com> <52876113.9090701@redhat.com> <20131117030202.GA3481@adacore.com> In-Reply-To: <20131117030202.GA3481@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00461.txt.bz2 On 11/17/2013 03:02 AM, Joel Brobecker wrote: > Thanks! Patch now pushed. I've pushed this obvious patch too. ------- Simplify dwarf2-frame.c:read_addr_from_reg. Since 'struct dwarf_expr_context_funcs::read_addr_from_reg' is now only used for addresses, we can make it use unpack_pointer. And since we now have 'struct dwarf_expr_context_funcs'::get_reg_value, there's no need for speculation about using values here. Tested on x86_64 Fedora 17. gdb/ 2013-11-18 Pedro Alves * dwarf2-frame.c (read_addr_from_reg): Remove stale comment and use unpack_pointer. --- gdb/ChangeLog | 5 +++++ gdb/dwarf2-frame.c | 7 +------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 53de4fb..7fc09e0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2013-11-18 Pedro Alves + + * dwarf2-frame.c (read_addr_from_reg): Remove stale comment and + use unpack_pointer. + 2013-11-18 Joel Brobecker * mi/mi-main.c (mi_cmd_list_features): Add "language-options" diff --git a/gdb/dwarf2-frame.c b/gdb/dwarf2-frame.c index b53c015..cd4f47c 100644 --- a/gdb/dwarf2-frame.c +++ b/gdb/dwarf2-frame.c @@ -298,12 +298,7 @@ read_addr_from_reg (void *baton, int reg) buf = alloca (register_size (gdbarch, regnum)); get_frame_register (this_frame, regnum, buf); - /* Convert the register to an integer. This returns a LONGEST - rather than a CORE_ADDR, but unpack_pointer does the same thing - under the covers, and this makes more sense for non-pointer - registers. Maybe read_addr_from_reg and the associated interfaces - should deal with "struct value" instead of CORE_ADDR. */ - return unpack_long (register_type (gdbarch, regnum), buf); + return unpack_pointer (register_type (gdbarch, regnum), buf); } /* Implement struct dwarf_expr_context_funcs' "get_reg_value" callback. */