From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16731 invoked by alias); 16 Nov 2013 12:12:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16720 invoked by uid 89); 16 Nov 2013 12:12:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 16 Nov 2013 12:12:15 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAGCC6Gb015949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 16 Nov 2013 07:12:07 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAGCC4rX024850; Sat, 16 Nov 2013 07:12:06 -0500 Message-ID: <52876113.9090701@redhat.com> Date: Sun, 17 Nov 2013 03:02:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFA] Rename "read_reg" into "read_addr_from_reg" in struct dwarf_expr_context_funcs References: <5286326C.8010204@redhat.com> <1384573853-25378-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1384573853-25378-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00439.txt.bz2 On 11/16/2013 03:50 AM, Joel Brobecker wrote: > Hello, > > This implements the suggestion discussed at: > http://www.sourceware.org/ml/gdb-patches/2013-11/msg00412.html > > ~~~ > > This is to help make it slightly clearer how this method is expected > to extract data from the given register. > > gdb/ChangeLog: > > * dwarf2expr.h (struct dwarf_expr_context_funcs) > : Renames "read_reg". > * dwarf2-frame.c (read_addr_from_reg): Renames "read_reg". > Adjust comment. > (dwarf2_frame_ctx_funcs, execute_stack_op, dwarf2_frame_cache): > Use read_addr_from_reg in place of read_reg. > * dwarf2expr.c (execute_stack_op): Use read_addr_from_reg > in place of read_reg. > * dwarf2loc.c (dwarf_expr_read_addr_from_reg): Renames > dwarf_expr_read_reg. > (dwarf_expr_ctx_funcs): Replace dwarf_expr_read_reg > with dwarf_expr_read_addr_from_reg. > (needs_frame_read_addr_from_reg): Renames needs_frame_read_reg. > (needs_frame_ctx_funcs): Replace needs_frame_read_reg with > needs_frame_read_addr_from_reg. > > Tested on x86_64-linux. OK to commit? Looks good to me. Thanks! -- Pedro Alves