From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30853 invoked by alias); 14 Nov 2013 11:23:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30754 invoked by uid 89); 14 Nov 2013 11:23:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_40,RDNS_NONE autolearn=no version=3.3.2 X-HELO: mms1.broadcom.com Received: from Unknown (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2013 11:23:52 +0000 Received: from [10.9.208.57] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Thu, 14 Nov 2013 03:23:26 -0800 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Thu, 14 Nov 2013 03:23:40 -0800 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.1.438.0; Thu, 14 Nov 2013 03:23:40 -0800 Received: from [10.177.73.52] (unknown [10.177.73.52]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 0430C246A4; Thu, 14 Nov 2013 03:23:39 -0800 (PST) Message-ID: <5284B2BB.3090800@broadcom.com> Date: Thu, 14 Nov 2013 12:26:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org, "Tom Tromey" Subject: Re: [PATCH] use error, not internal_error, in dwarf2-frame.c References: <1384375392-32110-1-git-send-email-tromey@redhat.com> In-Reply-To: <1384375392-32110-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00370.txt.bz2 On 13/11/2013 8:43 PM, Tom Tromey wrote: > > I think that gdb should not call internal_error for bad DWARF. > Instead, it should simply throw an ordinary exception. Sounds reasonable. > > diff --git a/gdb/dwarf2-frame.c b/gdb/dwarf2-frame.c > index e05236f..8f55e9f 100644 > --- a/gdb/dwarf2-frame.c > +++ b/gdb/dwarf2-frame.c > @@ -680,8 +680,7 @@ bad CFI data; mismatched DW_CFA_restore_state at %s"), > break; > > default: > - internal_error (__FILE__, __LINE__, > - _("Unknown CFI encountered.")); > + error (_("Unknown CFI encountered.")); I wonder if we could make this error message clearer? Will an "average" user understand what a CFI is? How about something like: "Invalid DWARF debugging information: Unknown CFI encountered" This might give a better idea what is going on. If you agree then the same applies to the rest of these errors too. Just a thought. Thanks, Andrew