Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: John Baldwin <john@baldwin.cx>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Update gdb's configure instructions
Date: Fri, 14 Sep 2018 16:17:00 -0000	[thread overview]
Message-ID: <528398ce-fae6-f8c7-0f0b-8b37bbe7871a@baldwin.cx> (raw)
In-Reply-To: <20180914042946.29248-1-tom@tromey.com>

On 9/13/18 9:29 PM, Tom Tromey wrote:
> diff --git a/gdb/README b/gdb/README
> index e43887ffcdf..d7ab18ccc6a 100644
> --- a/gdb/README
> +++ b/gdb/README
> @@ -77,8 +73,8 @@ such as:
>     If you get other compiler errors during this stage, see the `Reporting
>  Bugs' section below; there are a few known problems.
>  
> -   GDB requires an ISO C (ANSI C) compiler.  If you do not have an ISO
> -C compiler for your system, you may be able to download and install
> +   GDB requires a C++ compiler.  If you do not have a
> +C++ compiler for your system, you may be able to download and install
>  the GNU CC compiler.  It is available via anonymous FTP from the
>  directory `ftp://ftp.gnu.org/pub/gnu/gcc'.  GDB also requires an ISO
>  C standard library.  The GDB remote server, GDBserver, builds with some

I would perhaps say "C++11" compiler rather than just C++.  Also, might want
to say "GNU C++ compiler" here as I noticed you did make that update in some
other places further down.

> @@ -392,25 +388,12 @@ prefer; but you may abbreviate option names if you use `--'.
>  `--enable-build-warnings'
>       When building the GDB sources, ask the compiler to warn about any
>       code which looks even vaguely suspicious.  You should only using
> -     this feature if you're compiling with GNU CC.  It passes the
> -     following flags:
> -	-Wimplicit
> -	-Wreturn-type
> -	-Wcomment
> -	-Wtrigraphs
> -	-Wformat
> -	-Wparentheses
> -	-Wpointer-arith
> +     this feature if you're compiling with the GNU C++ compiler.  It
> +     passes many different warning flags, depending on the exact
> +     version of the compiler you are using.

In practice we seem to enable warnings on all compilers, not just GCC?
(Certainly they are enabled out-of-the-box when building with clang as cc)
  
>  `--enable-werror'
>       Treat compiler warnings as werrors.  Use this only with GCC.  It

Same is true for -Werror.

-- 
John Baldwin

                                                                            


  parent reply	other threads:[~2018-09-14 16:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14  4:30 Tom Tromey
2018-09-14  8:28 ` Eli Zaretskii
2018-09-27 22:20   ` Tom Tromey
2018-09-28  7:41     ` Eli Zaretskii
2018-09-28 20:01       ` Tom Tromey
2018-09-28 21:18         ` Eli Zaretskii
2018-09-14 16:17 ` John Baldwin [this message]
2018-09-27 22:21   ` Tom Tromey
2018-09-28 16:24     ` John Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528398ce-fae6-f8c7-0f0b-8b37bbe7871a@baldwin.cx \
    --to=john@baldwin.cx \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox