From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24316 invoked by alias); 12 Nov 2013 09:18:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24299 invoked by uid 89); 12 Nov 2013 09:18:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_20,RDNS_NONE autolearn=no version=3.3.2 X-HELO: mms2.broadcom.com Received: from Unknown (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2013 09:18:31 +0000 Received: from [10.9.208.55] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Tue, 12 Nov 2013 01:17:51 -0800 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS07.corp.ad.broadcom.com (10.9.208.55) with Microsoft SMTP Server (TLS) id 14.1.438.0; Tue, 12 Nov 2013 01:18:18 -0800 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Tue, 12 Nov 2013 01:18:18 -0800 Received: from [10.177.73.52] (unknown [10.177.73.52]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id C5F06246A4 for ; Tue, 12 Nov 2013 01:18:17 -0800 (PST) Message-ID: <5281F259.8090602@broadcom.com> Date: Tue, 12 Nov 2013 09:37:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: PING: Re: [RFC 00/12] Merge value optimized_out and unavailable References: <5208D1DF.1090201@broadcom.com> <521F82F6.70208@broadcom.com> In-Reply-To: <521F82F6.70208@broadcom.com> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00309.txt.bz2 On 29/08/2013 6:20 PM, Andrew Burgess wrote: > Ping! Ping #2! It's been a while, but I still have interest in merging this work. I've not checked to see if the patches still apply, if there's anyone who's willing to review this work then let me know and I'll refresh the patch series. I know I'm still a fairly new / small time contributor to gdb, and this patch set is a refactor, not a bug fix, so I might be getting ahead of myself trying to have something like this merged :) That's OK, if you let me know then I'll not spend any more time on this work. Thanks, Andrew > On 12/08/2013 1:15 PM, Andrew Burgess wrote: >> This patch set merges together how gdb handles values that are >> optimized out and values that are unavailable. >> >> I think that in most cases gdb should not care why the contents of >> a value are not fetch-able, it is only when we need to display >> something to the user that we should have to figure out was this >> optimized-out or unavailable? >> >> After this patch set there will be a single unified interface to ask >> if a value is available (either fully, partially, or for a range of >> bit/bytes), this will answer in terms of both optimized out and >> unavailable state. >> >> A second method will fetch the set of flags for the value >> optimized/unavailable, this will be used for printing the correct string. >> >> For the implementation I've moved away from the code we currently have >> for supporting partially optimized out values and consolidated on the >> unavailable vector. >> >> Currently within gdb there are places where we handle optimized out and >> unavailable differently, resulting in different style of output, and there >> are places where we handle one of optimized out or unavailable, but not the >> other. After this patch set it should (I hope) be much harder for either >> of these situations to arise. >> >> Looking forward to your feedback. >> >> Thanks, >> Andrew >>