From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21269 invoked by alias); 11 Nov 2013 08:31:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21249 invoked by uid 89); 11 Nov 2013 08:31:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.7 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Nov 2013 08:31:15 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Vfmtg-0006Qf-FH from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 11 Nov 2013 00:31:00 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 11 Nov 2013 00:31:00 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Mon, 11 Nov 2013 00:30:59 -0800 Message-ID: <52809570.5030100@codesourcery.com> Date: Mon, 11 Nov 2013 09:38:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Subject: Re: [PATCH 00/10 V2] Cache code access for disassemble References: <1383458049-20893-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1383458049-20893-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00279.txt.bz2 On 11/03/2013 01:54 PM, Yao Qi wrote: > This is the V2 of this patch series. In the discussion of V1, the > major comments are: > > 1. dcache.c and target_dcache needs some cleanups and factor. > 2. commands "set dcache size" and "set dcahce line-size" needs a > description on semantics when dcache is per-address_space. > 3. Use a single global 'target_dcache' for both stack caching and > code caching. > 4. Replace "executable code" with "code segment" in doc and NEWS. > > V2 addresses these comments as follows: > > Patch #1 ~ #4 are about cleanups and factors to dcache.c and > target_dcache. Patch #5 is a minor optimization to target_dcache. > Patch #6 and #7 change target_dcache to per-address_space mode, and > update doc on dcache-related commands. > > We decide to use single 'target_dcache' for caching different types > of access, so cache invalidation caused by option "stack-cache" > changes makes troubles. Think a little, I find we don't have to > invalidate target_dcache when option "stack-cache" is changed. This > is what patch #8 does, and looks change in patch #8 doesn't affect > the semantics of option "set stack-cache". > > Patch #9 adds command "set code-cache", similar to "set stack-cache", and > patch #10 is to use TARGET_OBJECT_CODE_MEMORY to read for disassembly. > > Patch 4, 5, 7, and 9 need doc review. > > Each patch is regression tested on x86_64-linux. Ping. https://sourceware.org/ml/gdb-patches/2013-11/msg00040.html -- Yao (齐尧)