From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3827 invoked by alias); 8 Nov 2013 12:46:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3814 invoked by uid 89); 8 Nov 2013 12:46:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.6 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPAM_SUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2013 12:46:06 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA8Cjvuk021673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Nov 2013 07:45:57 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA8Cjtox006677; Fri, 8 Nov 2013 07:45:56 -0500 Message-ID: <527CDD03.9000200@redhat.com> Date: Fri, 08 Nov 2013 13:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFA/Ada(v2) 1/3] Add command to list Ada exceptions References: <1383912219-13012-1-git-send-email-brobecker@adacore.com> <1383912219-13012-2-git-send-email-brobecker@adacore.com> In-Reply-To: <1383912219-13012-2-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00235.txt.bz2 Hi Joel, Only minor comments. On 11/08/2013 12:03 PM, Joel Brobecker wrote: > (DEF_VEC_O(ada_exc_info): New vector. Something odd here. > gdb/testsuite/ChangeLog: > > * info_exc: New testcase. gdb.ada missing. > + /* Next, find all exceptions whose scope is local and accessible > + from the currently selected frame. */ > + > + if (target_has_registers) > + { Should be has_stack_frames. -- Pedro Alves