From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24569 invoked by alias); 8 Nov 2013 12:27:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24554 invoked by uid 89); 8 Nov 2013 12:27:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.6 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPAM_SUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2013 12:27:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA8CRe45007273 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Nov 2013 07:27:41 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA8CRdpk008222; Fri, 8 Nov 2013 07:27:39 -0500 Message-ID: <527CD8BB.3000103@redhat.com> Date: Fri, 08 Nov 2013 12:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/6] introduce common.m4 References: <1383675811-3274-1-git-send-email-tromey@redhat.com> <1383675811-3274-2-git-send-email-tromey@redhat.com> <5279425C.7020201@redhat.com> <87zjpipqx9.fsf@fleche.redhat.com> In-Reply-To: <87zjpipqx9.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00234.txt.bz2 On 11/05/2013 07:52 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> HAVE_LANGINFO_CODESET is used by common/gdb_locale.h, > Pedro> and GDB_AC_COMMON uses AM_LANGINFO_CODESET. Shouldn't > Pedro> codeset.m4 then be included by common.m4 instead? > > It's also needed by gdb/charset.c, so technically it should be included > in both places. However it seems strange to include the file twice, and > reasonably harmless the way it is. Hmm, but then this goes against the "each module includes what it needs" philosophy. Does including the file twice actually result in expanding the file twice, or does m4 make sure it's included only once? If we do go with gdbserver including this directly, then I think it'd be good to add a comment about the dependency here: > +++ b/gdb/gdbserver/acinclude.m4 > @@ -12,8 +12,10 @@ sinclude(../../config/override.m4) > dnl For ACX_PKGVERSION and ACX_BUGURL. > sinclude(../../config/acx.m4) > > +m4_include(../../config/codeset.m4) > m4_include(../../config/depstand.m4) > m4_include(../../config/lead-dot.m4) > +m4_include(../common/common.m4) Thanks, -- Pedro Alves