From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5766 invoked by alias); 7 Nov 2013 15:44:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5714 invoked by uid 89); 7 Nov 2013 15:44:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPAM_SUBJECT,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Nov 2013 15:43:16 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA7Fh93v019636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Nov 2013 10:43:09 -0500 Received: from localhost.localdomain (ovpn-112-33.ams2.redhat.com [10.36.112.33]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rA7Fh7a8004022; Thu, 7 Nov 2013 10:43:08 -0500 Message-ID: <527BB50B.5030506@redhat.com> Date: Thu, 07 Nov 2013 15:46:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [patch][python] 2/3 Python representation of GDB line tables (Testsuite) References: <5253F4DD.4000104@redhat.com> <87k3h3d802.fsf@fleche.redhat.com> In-Reply-To: <87k3h3d802.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00185.txt.bz2 On 23/10/13 21:53, Tom Tromey wrote: >>>>>> "Phil" == Phil Muldoon writes: > > Phil> This patch in the series contains the testsuite code for Python > Phil> linetables. > > Phil> diff --git a/gdb/testsuite/gdb.python/py-linetable.S > Phil> b/gdb/testsuite/gdb.python/py-linetable.S > Phil> new file mode 100644 > Phil> index 0000000..5957222 > Phil> --- /dev/null > Phil> +++ b/gdb/testsuite/gdb.python/py-linetable.S > Phil> @@ -0,0 +1,345 @@ > Phil> + .file "py-linetable.c" > Phil> + .text > Phil> +.Ltext0: > > Normally we hack in a comment header at the top. > > I wonder whether assembly is truly needed in this case. It was included at Jan's suggestion. To ensure compatibility between compiler versions. However, the test is compiled unoptimized so I suspect the potential of change in the linetable between versions is slim. I have no strong opinion. What do you think? > > Phil> +# > Phil> +# You should have received a copy of the GNU General Public License > Phil> +# along with this program. If not, see . > Phil> +load_lib gdb-python.exp > Phil> +set opts {} > Phil> +standard_testfile .S > > Blank line between comments and code. > > Phil> +gdb_py_test_silent_cmd "python lt = > Phil> gdb.selected_frame().find_sal().symtab.linetable()" \ > > Your patch got wrapped. No idea how this happened. It was produced by git format-patch, and the file inserted into the email (IE, not copy and pasted). So that was weird. Regards Phil