From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5872 invoked by alias); 6 Nov 2013 22:23:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5857 invoked by uid 89); 6 Nov 2013 22:23:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: elasmtp-scoter.atl.sa.earthlink.net Received: from Unknown (HELO elasmtp-scoter.atl.sa.earthlink.net) (209.86.89.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2013 22:23:25 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-scoter.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1VeBVO-0001lv-9j for gdb-patches@sourceware.org; Wed, 06 Nov 2013 17:23:18 -0500 Message-ID: <527AC155.4080004@earthlink.net> Date: Thu, 07 Nov 2013 01:05:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix Gold/strip discrepancies for PR 11786 References: <20131031154957.GA11260@host2.jankratochvil.net> <87li13shk2.fsf@fleche.redhat.com> <20131105172219.GA21529@host2.jankratochvil.net> <20131105180547.GA24004@host2.jankratochvil.net> <20131106212434.GA4193@host2.jankratochvil.net> In-Reply-To: <20131106212434.GA4193@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940d1e1432772b82f8063a099097e663ea2350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00159.txt.bz2 On 11/6/13 1:24 PM, Jan Kratochvil wrote: > On Wed, 06 Nov 2013 22:14:27 +0100, Doug Evans wrote: >> It will basically say tests are in general not required to following >> the GDB coding standards, > > What is the reason for it? > > I would find more logical to say tests should follow the same rules as GDB > code, unless there is a specific reason for it. Such as importing an existing > external reproducer, machine generated output etc. > > If GDB coding standards are not acceptable for testcases then it looks to me > as an indication the GDB coding standards should be changed. The point of the testsuite is to check GDB behavior on programs in general. We would look pretty foolish if someone were to encounter a GDB bug that only occurred in source that did not follow the GDB standard, and we were unable to detect it because our regression tests did not include code written in a variety of styles. As examples, the GNU style prefers to have braces on lines by themselves, and to not have side-effecting code in conditionals, even though there are millions of lines of code written that way. Without a testsuite including these common usages, it would be easy to introduce bugs in single-stepping and breakpoint handling that our regression testing could not catch. Stan stan@codesourcery.com