From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32150 invoked by alias); 6 Nov 2013 21:28:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32139 invoked by uid 89); 6 Nov 2013 21:28:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: elasmtp-scoter.atl.sa.earthlink.net Received: from Unknown (HELO elasmtp-scoter.atl.sa.earthlink.net) (209.86.89.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2013 21:28:43 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-scoter.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1VeAeR-0003Yv-BC for gdb-patches@sourceware.org; Wed, 06 Nov 2013 16:28:35 -0500 Message-ID: <527AB482.80600@earthlink.net> Date: Wed, 06 Nov 2013 21:35:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940b764047ececb9df08647e9ba271787c8350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00151.txt.bz2 On 11/6/13 9:00 AM, Doug Evans wrote: > Hi. > > There's nothing python-specific about the bulk of this code so I've > moved it out of py-type.c. > > Ok to check in? > > 2013-11-06 Doug Evans > > * gdbtypes.c: #include bcache.h, dwarf2loc.h. > (type_equality_entry): Move here from python/py-type.c. > (type_equality_entry_d): Ditto. > (compare_maybe_null_strings, check_types_equal): Ditto. > (check_types_worklist, types_deeply_equal): Ditto. > * gdbtypes.h (types_deeply_equal): Declare. > * python/py-type.c: Remove inclusion of bcache.h, dwarf2loc.h. > (typy_richcompare): Update. > +/* A helper function for tyscm_richcompare that checks two types for + "deep" equality. Returns non-zero if the types are considered the + same, zero otherwise. */ "tyscm_richcompare"? Should that be typy_... ? The comments should be maybe be phrased to emphasize the quasi-librariness of the code, so that future generations aren't confused if it seems unused by core GDB (which could happen if python becomes plugin instead of subdir, for example). Stan stan@codesourcery.com