From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9651 invoked by alias); 5 Nov 2013 19:10:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9641 invoked by uid 89); 5 Nov 2013 19:10:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2013 19:10:15 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA5JA7Zq014801 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Nov 2013 14:10:08 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rA5JA5bv022373; Tue, 5 Nov 2013 14:10:06 -0500 Message-ID: <5279428D.8070800@redhat.com> Date: Tue, 05 Nov 2013 19:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/6] use gdb_string.h in m32c-tdep.c References: <1383675811-3274-1-git-send-email-tromey@redhat.com> <1383675811-3274-4-git-send-email-tromey@redhat.com> In-Reply-To: <1383675811-3274-4-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00098.txt.bz2 On 11/05/2013 06:23 PM, Tom Tromey wrote: > m32c-tdep.c is the last user of HAVE_STRING_H in gdb proper. It > really ought to be using gdb_string.h instead, as the rest of gdb > does. > > 2013-11-05 Tom Tromey > > * m32c-tdep.c: Use gdb_string.h. Looks obviously good to me. Thanks, -- Pedro Alves