From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14031 invoked by alias); 30 Oct 2013 17:13:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14018 invoked by uid 89); 30 Oct 2013 17:13:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mms2.broadcom.com Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2013 17:13:30 +0000 Received: from [10.9.208.57] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Wed, 30 Oct 2013 10:13:09 -0700 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Wed, 30 Oct 2013 10:13:20 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Wed, 30 Oct 2013 10:13:20 -0700 Received: from [10.177.73.52] (unknown [10.177.73.52]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 1F40D246A3; Wed, 30 Oct 2013 10:13:19 -0700 (PDT) Message-ID: <52713E2F.2030709@broadcom.com> Date: Wed, 30 Oct 2013 17:13:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: "Eli Zaretskii" cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Extra error message from update_watchpoint References: <5260FD66.7090506@broadcom.com> <52616D4B.3020209@redhat.com> <526FE5E9.3000909@broadcom.com> <83ob68dmfb.fsf@gnu.org> <526FF27B.8090209@broadcom.com> <5270F23E.7010602@broadcom.com> <83a9hqepgt.fsf@gnu.org> In-Reply-To: <83a9hqepgt.fsf@gnu.org> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00925.txt.bz2 On 30/10/2013 3:41 PM, Eli Zaretskii wrote: >> Date: Wed, 30 Oct 2013 11:49:18 +0000 >> From: "Andrew Burgess" >> cc: gdb-patches@sourceware.org >> >> OK, here are a few alternatives, feel free to pick your favourites: >> >> (1) The original: >> error (_("Software read/access watchpoints not supported.")); >> >> (2) Pedro's original replacement: >> error (_("Hardware watchpoint support disabled. " >> "See set/show can-use-hw-watchpoints.")); >> >> (3) The original + why we can't use H/W watchpoints (bit long): >> error (_("Software read/access watchpoints not supported, " >> "re-enable hardware watchpoints using " >> "\"set can-use-hw-watchpoints 1\"")); >> >> (4) Same, but with a newline to keep it under 80 chars, not sure if >> multi-line errors are acceptable though. >> error (_("Software read/access watchpoints not supported.\n" >> "Enable hardware watchpoints using " >> "\"set can-use-hw-watchpoints 1\"")); >> >> (5) Mention that H/W watchpoints are disabled, but not how to re-enable >> them, though given the user has done the disabling this might be enough >> to prompt them. This is single line, and just under 80 chars. >> error (_("Software read/access watchpoints not supported, " >> "hardware watchpoints disabled.")); >> >> >> My favourite is (5) at the moment, but I'll take whatever makes everyone >> else happy :) > > None of the above really explains to the user why GDB is going to > refuse to abide by her command. > > A good message should say something like "Cannot do SOMETHING because > SOME-REASON." > > But I don't want to be in the position of blocking a commit due to > something that is just MO, so feel free to ignore me. I'd rather make you happy if possible, never hurts to suck up right ;-) The following follows the structure you gave, I'd be happy to go with this except that it's longer than 80 character... is that an issue? "Can't set read/access watchpoint, software read/access watchpoints not supported, and hardware watchpoints disabled (see set/show can-use-hw-watchpoints)." Thanks, Andrew