From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10308 invoked by alias); 29 Oct 2013 17:52:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10294 invoked by uid 89); 29 Oct 2013 17:52:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Oct 2013 17:52:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9THqmRE010095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 Oct 2013 13:52:48 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9THqlKC012583; Tue, 29 Oct 2013 13:52:47 -0400 Message-ID: <526FF5EE.2070509@redhat.com> Date: Tue, 29 Oct 2013 17:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Burgess CC: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH] Extra error message from update_watchpoint References: <5260FD66.7090506@broadcom.com> <52616D4B.3020209@redhat.com> <526FE5E9.3000909@broadcom.com> <83ob68dmfb.fsf@gnu.org> <526FF27B.8090209@broadcom.com> In-Reply-To: <526FF27B.8090209@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00910.txt.bz2 On 10/29/2013 05:38 PM, Andrew Burgess wrote: > On 29/10/2013 5:19 PM, Eli Zaretskii wrote: >>> Date: Tue, 29 Oct 2013 16:44:25 +0000 >>> From: "Andrew Burgess" >>> cc: "Pedro Alves" >>> >>> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c >>> index 608463d..68b348d 100644 >>> --- a/gdb/breakpoint.c >>> +++ b/gdb/breakpoint.c >>> @@ -1805,7 +1805,8 @@ update_watchpoint (struct watchpoint *b, int reparse) >>> if (b->base.ops->works_in_software_mode (&b->base)) >>> b->base.type = bp_watchpoint; >>> else >>> - error (_("Software read/access watchpoints not supported.")); >>> + error (_("Hardware watchpoint support disabled. " >>> + "See set/show can-use-hw-watchpoints.")); >> >> Sorry for chiming in late, but IMO this change is a step backwards: >> the new warning is much more puzzling than the old one. The old one >> at least told what was the problem, the new one looks like entirely >> unrelated (unless you are privy to GDB internals). >> >> How about something like >> >> Cannot set read/access watchpoints without hardware watchpoint support. > > > If Pedro is happy then I too am happy, ;-) I'm happy. Eli, it wasn't clear to me from your suggestion -- do you think the "See set/show can-use-hw-watchpoints." part should or shouldn't be there? (the case here isn't that the target doesn't support these watchpoint types, but that support has been manually disabled) > my original issue was for the case where turning H/W watchpoints > off resulted in the error: > Expression cannot be implemented with read/access watchpoint. > > which confused me. Anything that's been suggested so far is better than > the original behaviour :) -- Pedro Alves