From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27423 invoked by alias); 29 Oct 2013 17:38:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27414 invoked by uid 89); 29 Oct 2013 17:38:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mms1.broadcom.com Received: from mms1.broadcom.com (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Oct 2013 17:38:17 +0000 Received: from [10.9.208.57] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Tue, 29 Oct 2013 10:38:01 -0700 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Tue, 29 Oct 2013 10:38:05 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Tue, 29 Oct 2013 10:38:05 -0700 Received: from [10.177.73.52] (unknown [10.177.73.52]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 7D26D246AA; Tue, 29 Oct 2013 10:38:04 -0700 (PDT) Message-ID: <526FF27B.8090209@broadcom.com> Date: Tue, 29 Oct 2013 17:38:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: "Eli Zaretskii" , palves@redhat.com cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Extra error message from update_watchpoint References: <5260FD66.7090506@broadcom.com> <52616D4B.3020209@redhat.com> <526FE5E9.3000909@broadcom.com> <83ob68dmfb.fsf@gnu.org> In-Reply-To: <83ob68dmfb.fsf@gnu.org> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00907.txt.bz2 On 29/10/2013 5:19 PM, Eli Zaretskii wrote: >> Date: Tue, 29 Oct 2013 16:44:25 +0000 >> From: "Andrew Burgess" >> cc: "Pedro Alves" >> >> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c >> index 608463d..68b348d 100644 >> --- a/gdb/breakpoint.c >> +++ b/gdb/breakpoint.c >> @@ -1805,7 +1805,8 @@ update_watchpoint (struct watchpoint *b, int reparse) >> if (b->base.ops->works_in_software_mode (&b->base)) >> b->base.type = bp_watchpoint; >> else >> - error (_("Software read/access watchpoints not supported.")); >> + error (_("Hardware watchpoint support disabled. " >> + "See set/show can-use-hw-watchpoints.")); > > Sorry for chiming in late, but IMO this change is a step backwards: > the new warning is much more puzzling than the old one. The old one > at least told what was the problem, the new one looks like entirely > unrelated (unless you are privy to GDB internals). > > How about something like > > Cannot set read/access watchpoints without hardware watchpoint support. If Pedro is happy then I too am happy, my original issue was for the case where turning H/W watchpoints off resulted in the error: Expression cannot be implemented with read/access watchpoint. which confused me. Anything that's been suggested so far is better than the original behaviour :) thanks, Andrew