From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20817 invoked by alias); 28 Oct 2013 15:20:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20755 invoked by uid 89); 28 Oct 2013 15:20:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2013 15:20:20 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9SFKIVD032520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Oct 2013 11:20:19 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9SFKHvI018969; Mon, 28 Oct 2013 11:20:18 -0400 Message-ID: <526E80B1.6060202@redhat.com> Date: Mon, 28 Oct 2013 15:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v4 1/9] fix latent bugs in ui-out.c References: <1382464769-2465-1-git-send-email-tromey@redhat.com> <1382464769-2465-2-git-send-email-tromey@redhat.com> In-Reply-To: <1382464769-2465-2-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00862.txt.bz2 On 10/22/2013 06:59 PM, Tom Tromey wrote: > The destructor code in ui-out.c has a latent bug, which is hidden by > the fact that nothing uses this right now. This patch fixes the > problem. The bug is that we don't always clear a pointer in the > ui-out object, leading to bad a free. "to a bad free" > > * ui-out.c (clear_table, ui_out_new): Clear uiout->table.id. Looks good to me. -- Pedro Alves