From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix ada inferior-data cleanup
Date: Mon, 28 Oct 2013 11:28:00 -0000 [thread overview]
Message-ID: <526E4A3D.60503@redhat.com> (raw)
In-Reply-To: <1382759789-777-1-git-send-email-yao@codesourcery.com>
On 10/26/2013 04:56 AM, Yao Qi wrote:
> 'struct ada_inferior_data' is registered to per-inferior-data with
> cleanup ada_inferior_data_cleanup, which means the data will be
> destroyed when the inferior exits.
That's not correct. The registry data cleanups are only ran when
the inferior object is destroyed, IOW, when the inferior is
removed/deleted (e.g, with "remove-inferiors"), not when the program
exits.
> It is unnecessary to call
> observer_attach_inferior_exit to do cleanups again.
>
> Regression tested by "make check RUNTESTFLAGS='--directory=gdb.ada'"
> on x86 Fedora 16 linux.
--
Pedro Alves
next prev parent reply other threads:[~2013-10-28 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 3:58 Yao Qi
2013-10-28 3:43 ` Joel Brobecker
2013-10-28 12:06 ` Yao Qi
2013-10-28 11:28 ` Pedro Alves [this message]
2013-10-28 12:24 ` Yao Qi
2013-10-28 14:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E4A3D.60503@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox