Re: [PATCH 3/3] Remove varobj_language_string, languages and varobj_languages

Tom Tromey
2013-10-28T18:52:01Z

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> This patch does some cleanups, removing some language-related stuff.
Yao> Note that mi_cmd_var_info_expression uses varobj_language_string,
Yao> which is redundant, because we can get language name from
Yao> lang-> la_natural_name.

Yao> varobj_language_string doesn't have "Ada", which looks like a bug to
Yao> me. With this patch applied, this problem doesn't exist, because the
Yao> language name is got from the same place (field la_natural_name).

I think this is an improvement, and I'm inclined to approve it.
However, two thoughts.

First, it can change the language reported by varobj commands.
Does this matter?

Second, the MI docs have a list of languages that can be reported:

Here, the values of @code{lang} can be @code{@{"C" | "C++" | "Java"@}}.

I think this needs to be updated.

Tom