Re: [PATCH] Make STARTUP_WITH_SHELL a runtime toggle -- add new "set/show startup-with-shell" option.

Pedro Alves
2014-01-09T12:10:26Z

On 01/08/2014 09:20 PM, Thomas Schwinge wrote:
> Hi!
>
> On Thu, 24 Oct 2013 16:17:21 +0100, Pedro Alves <palves@redhat.com> wrote:
>> Here's what I pushed
>
> ..., and what made the Hurd port pretty unhappy. ;-)

Whoops. ;-) Thanks for fixing.

> In the thread around
> <http://news.gmane.org/find-root.php?message_id=%3C200810110047.39807.pedro%40codesourcery.com%3E>,
> and
> <http://news.gmane.org/find-root.php?message_id=%3C200810131935.35253.pedro%40codesourcery.com%3E>,
> we had already (very) briefly been discussing gnu-nat's local
> pending_execs handling.

Ah, these things do have a tendency to byte back.

> Is the new approach that I'm posting below (flag instead of counting;
> saves us from repeating in gnu_create_inferior the increment in the
> startup_with_shell case) OK until we get a clear understanding if and how
> we can get rid of it for good?

It's fine with me.

> commit 57c9fb3afadab5813d7463dc2393d5affe78849e
> Author: Thomas Schwinge <thomas@codesourcery.com>
> Date: Wed Jan 8 21:42:07 2014 +0100
>
> Hurd: Adjust to startup-with-shell changes.
>
> In commit 98882a26513e25b2161b41dfd4bed97b59b2c01a, STARTUP_WITH_SHELL was made
> a runtime toggle, startup-with-shell. The Hurd code not adjusted, which had a

"... code was not ..."

> value hard-coded instead of using START_INFERIOR_TRAPS_EXPECTED. Fix that, and
> also simplify gnu-nat's pending_execs handling from counting to just a flag.

--
Pedro Alves