From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30265 invoked by alias); 24 Oct 2013 14:13:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30249 invoked by uid 89); 24 Oct 2013 14:13:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Oct 2013 14:13:07 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VZLep-0004PA-Pd from Yao_Qi@mentor.com ; Thu, 24 Oct 2013 07:13:03 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 24 Oct 2013 07:13:03 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Thu, 24 Oct 2013 07:13:02 -0700 Message-ID: <52692A99.3080404@codesourcery.com> Date: Thu, 24 Oct 2013 14:13:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: "Agovic, Sanimir" CC: "gdb-patches@sourceware.org" Subject: Re: ping: [PATCH 0/4 V3] GDB Performance testing References: <1381907353-30013-1-git-send-email-yao@codesourcery.com> <52688937.4030600@codesourcery.com> <0377C58828D86C4588AEEC42FC3B85A71769EA52@IRSMSX105.ger.corp.intel.com> In-Reply-To: <0377C58828D86C4588AEEC42FC3B85A71769EA52@IRSMSX105.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00754.txt.bz2 On 10/24/2013 04:49 PM, Agovic, Sanimir wrote: > + def measure(self, func, id): > + """Measure the operations done by func with a collection of measurements.""" > + for m in self.measurements: > + m.start(id) > + > + # Enable GC, force GC and disable GC before running test in order to reduce > + # the interference from GC. > + gc.enable() > + gc.collect() > + gc.disable() > + > + func() > + > + gc.enable() > I`d rather exclude gc cycles completely from the measurements or include gc collection > _after_ you run your perf test. Otherwise the results will depend on the order the perf > tests are run. Right, we should disable gc before measurements are started and enable gc again when measurements are stopped. I'll update the patch. -- Yao (齐尧)